# network-manager-applet-0.9.9.0-7.git20131107.el7

## List of Defects

    Error: CHECKED_RETURN (CWE-252): [#def1]
    network-manager-applet-0.9.9.0/src/libnm-gtk/nm-wifi-dialog.c:536: check_return: Calling function "gtk_tree_model_get_iter_first(GtkTreeModel *, GtkTreeIter *)" without checking return value (as is done elsewhere 20 out of 23 times).
    network-manager-applet-0.9.9.0/src/connection-editor/ip4-routes-dialog.c:168: example_assign: Example1: Assigning: "iter_valid" = return value from "gtk_tree_model_get_iter_first(model, &tree_iter)".
    network-manager-applet-0.9.9.0/src/connection-editor/ip4-routes-dialog.c:170: example_checked: Example1 (cont.): "iter_valid" has its value checked in "iter_valid".
    network-manager-applet-0.9.9.0/src/connection-editor/ip6-routes-dialog.c:124: example_assign: Example2: Assigning: "iter_valid" = return value from "gtk_tree_model_get_iter_first(model, &tree_iter)".
    network-manager-applet-0.9.9.0/src/connection-editor/ip6-routes-dialog.c:126: example_checked: Example2 (cont.): "iter_valid" has its value checked in "iter_valid".
    network-manager-applet-0.9.9.0/src/connection-editor/nm-connection-list.c:238: example_checked: Example3: "gtk_tree_model_get_iter_first(list->model, &types_iter)" has its value checked in "gtk_tree_model_get_iter_first(list->model, &types_iter)".
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip4.c:1087: example_assign: Example4: Assigning: "iter_valid" = return value from "gtk_tree_model_get_iter_first(model, &tree_iter)".
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip4.c:1090: example_checked: Example4 (cont.): "iter_valid" has its value checked in "iter_valid".
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip6.c:1048: example_assign: Example5: Assigning: "iter_valid" = return value from "gtk_tree_model_get_iter_first(model, &tree_iter)".
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip6.c:1049: example_checked: Example5 (cont.): "iter_valid" has its value checked in "iter_valid".
    network-manager-applet-0.9.9.0/src/libnm-gtk/nm-wifi-dialog.c:536: unchecked_value: No check of the return value of "gtk_tree_model_get_iter_first(priv->connection_model, &tree_iter)".

    Error: CHECKED_RETURN (CWE-252): [#def2]
    network-manager-applet-0.9.9.0/src/libnm-gtk/nm-wifi-dialog.c:645: check_return: Calling function "gtk_tree_model_get_iter_first(GtkTreeModel *, GtkTreeIter *)" without checking return value (as is done elsewhere 20 out of 23 times).
    network-manager-applet-0.9.9.0/src/connection-editor/ip4-routes-dialog.c:168: example_assign: Example1: Assigning: "iter_valid" = return value from "gtk_tree_model_get_iter_first(model, &tree_iter)".
    network-manager-applet-0.9.9.0/src/connection-editor/ip4-routes-dialog.c:170: example_checked: Example1 (cont.): "iter_valid" has its value checked in "iter_valid".
    network-manager-applet-0.9.9.0/src/connection-editor/ip6-routes-dialog.c:124: example_assign: Example2: Assigning: "iter_valid" = return value from "gtk_tree_model_get_iter_first(model, &tree_iter)".
    network-manager-applet-0.9.9.0/src/connection-editor/ip6-routes-dialog.c:126: example_checked: Example2 (cont.): "iter_valid" has its value checked in "iter_valid".
    network-manager-applet-0.9.9.0/src/connection-editor/nm-connection-list.c:238: example_checked: Example3: "gtk_tree_model_get_iter_first(list->model, &types_iter)" has its value checked in "gtk_tree_model_get_iter_first(list->model, &types_iter)".
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip4.c:1087: example_assign: Example4: Assigning: "iter_valid" = return value from "gtk_tree_model_get_iter_first(model, &tree_iter)".
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip4.c:1090: example_checked: Example4 (cont.): "iter_valid" has its value checked in "iter_valid".
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip6.c:1048: example_assign: Example5: Assigning: "iter_valid" = return value from "gtk_tree_model_get_iter_first(model, &tree_iter)".
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip6.c:1049: example_checked: Example5 (cont.): "iter_valid" has its value checked in "iter_valid".
    network-manager-applet-0.9.9.0/src/libnm-gtk/nm-wifi-dialog.c:645: unchecked_value: No check of the return value of "gtk_tree_model_get_iter_first(priv->device_model, &iter)".

    Error: CHECKED_RETURN (CWE-252): [#def3]
    network-manager-applet-0.9.9.0/src/connection-editor/page-general.c:74: check_return: Calling function "dbus_g_proxy_end_call(DBusGProxy *, DBusGProxyCall *, GError **, GType, ...)" without checking return value (as is done elsewhere 15 out of 16 times).
    network-manager-applet-0.9.9.0/src/applet-device-cdma.c:508: example_checked: Example1: "dbus_g_proxy_end_call(proxy, call, &error, g_value_get_type(), &value, 0UL)" has its value checked in "dbus_g_proxy_end_call(proxy, call, &error, g_value_get_type(), &value, 0UL)".
    network-manager-applet-0.9.9.0/src/applet-device-cdma.c:440: example_checked: Example2: "dbus_g_proxy_end_call(proxy, call, &error, 28UL, &cdma1x_state, 28UL, &evdo_state, 0UL)" has its value checked in "dbus_g_proxy_end_call(proxy, call, &error, 28UL, &cdma1x_state, 28UL, &evdo_state, 0UL)".
    network-manager-applet-0.9.9.0/src/applet-device-gsm.c:936: example_checked: Example3: "dbus_g_proxy_end_call(proxy, call, &error, g_value_get_type(), &value, 0UL)" has its value checked in "dbus_g_proxy_end_call(proxy, call, &error, g_value_get_type(), &value, 0UL)".
    network-manager-applet-0.9.9.0/src/applet-device-gsm.c:644: example_checked: Example4: "dbus_g_proxy_end_call(proxy, call, &error, 28UL, &quality, 0UL)" has its value checked in "dbus_g_proxy_end_call(proxy, call, &error, 28UL, &quality, 0UL)".
    network-manager-applet-0.9.9.0/src/applet-device-gsm.c:858: example_checked: Example5: "dbus_g_proxy_end_call(proxy, call, &error, g_value_get_type(), &value, 0UL)" has its value checked in "dbus_g_proxy_end_call(proxy, call, &error, g_value_get_type(), &value, 0UL)".
    network-manager-applet-0.9.9.0/src/connection-editor/page-general.c:74: unchecked_value: No check of the return value of "dbus_g_proxy_end_call(proxy, call, &error, g_strv_get_type(), &priv->zones, 0UL)".

    Error: DEADCODE (CWE-561): [#def4]
    network-manager-applet-0.9.9.0/src/mobile-helpers.c:241: assignment: Assigning: "wizard_capability" = "NM_DEVICE_MODEM_CAPABILITY_CDMA_EVDO".
    network-manager-applet-0.9.9.0/src/mobile-helpers.c:269: const: At condition "wizard_capability == 2U", the value of "wizard_capability" must be equal to 2.
    network-manager-applet-0.9.9.0/src/mobile-helpers.c:269: dead_error_condition: The condition "wizard_capability == 2U" must be true.
    network-manager-applet-0.9.9.0/src/mobile-helpers.c:272: dead_error_begin: Execution cannot reach this statement "do {
      g_assertion_message(...".

    Error: DEADCODE (CWE-561): [#def5]
    network-manager-applet-0.9.9.0/src/connection-editor/page-dsl.c:71: assignment: Assigning: "secrets" = "NULL".
    network-manager-applet-0.9.9.0/src/connection-editor/page-dsl.c:82: null: At condition "secrets", the value of "secrets" must be NULL.
    network-manager-applet-0.9.9.0/src/connection-editor/page-dsl.c:82: dead_error_condition: The condition "secrets" cannot be true.
    network-manager-applet-0.9.9.0/src/connection-editor/page-dsl.c:83: dead_error_line: Execution cannot reach this statement "g_hash_table_destroy(secrets);".

    Error: FORWARD_NULL (CWE-476): [#def6]
    network-manager-applet-0.9.9.0/src/connection-editor/page-vlan.c:373: var_compare_op: Comparing "priv->s_hw" to null implies that "priv->s_hw" might be null.
    network-manager-applet-0.9.9.0/src/connection-editor/page-vlan.c:440: var_deref_model: Passing null pointer "priv->s_hw" to function "ce_get_property_default(NMSetting *, char const *)", which dereferences it.
    network-manager-applet-0.9.9.0/src/connection-editor/ce-page.c:84:2: deref_parm: Directly dereferencing parameter "setting".

    Error: FORWARD_NULL (CWE-476): [#def7]
    network-manager-applet-0.9.9.0/src/applet-device-gsm.c:484: var_compare_op: Comparing "error" to null implies that "error" might be null.
    network-manager-applet-0.9.9.0/src/applet-device-gsm.c:487: var_deref_op: Dereferencing null pointer "error".

    Error: FORWARD_NULL (CWE-476): [#def8]
    network-manager-applet-0.9.9.0/src/applet-device-gsm.c:542: var_compare_op: Comparing "code1" to null implies that "code1" might be null.
    network-manager-applet-0.9.9.0/src/applet-device-gsm.c:544: var_deref_model: Passing null pointer "code1" to function "strlen(char const *)", which dereferences it.

    Error: FORWARD_NULL (CWE-476): [#def9]
    network-manager-applet-0.9.9.0/src/applet-device-gsm.c:507: var_compare_op: Comparing "error" to null implies that "error" might be null.
    network-manager-applet-0.9.9.0/src/applet-device-gsm.c:510: var_deref_op: Dereferencing null pointer "error".

    Error: NO_EFFECT (CWE-398): [#def10]
    network-manager-applet-0.9.9.0/src/ap-menu-item.c:154: unsigned_compare: This less-than-zero comparison of an unsigned value is never true. "strength < 0".

    Error: NO_EFFECT (CWE-398): [#def11]
    network-manager-applet-0.9.9.0/src/connection-editor/ip4-routes-dialog.c:429: unsigned_compare: This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "tmp_prefix >= 0U".

    Error: NO_EFFECT (CWE-398): [#def12]
    network-manager-applet-0.9.9.0/src/applet-device-wifi.c:1289: unsigned_compare: This less-than-zero comparison of an unsigned value is never true. "strength < 0U".

    Error: REVERSE_INULL (CWE-476): [#def13]
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip6.c:1113: alias: Assigning: "iter" = "items".
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip6.c:1113: deref_ptr: Directly dereferencing pointer "iter".
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip6.c:1135: alias: Assigning: "iter" = "items".
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip6.c:1135: deref_ptr: Directly dereferencing pointer "iter".
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip6.c:1142: check_after_deref: Null-checking "items" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

    Error: REVERSE_INULL (CWE-476): [#def14]
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip4.c:1154: alias: Assigning: "iter" = "items".
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip4.c:1154: deref_ptr: Directly dereferencing pointer "iter".
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip4.c:1175: alias: Assigning: "iter" = "items".
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip4.c:1175: deref_ptr: Directly dereferencing pointer "iter".
    network-manager-applet-0.9.9.0/src/connection-editor/page-ip4.c:1182: check_after_deref: Null-checking "items" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

    Error: UNUSED_VALUE (CWE-563): [#def15]
    network-manager-applet-0.9.9.0/src/applet-dialogs.c:234: returned_pointer: Pointer "s_wireless" returned by "nm_connection_get_setting_wireless(connection)" is never used.

    Error: UNUSED_VALUE (CWE-563): [#def16]
    network-manager-applet-0.9.9.0/src/applet-dialogs.c:960: returned_pointer: Pointer "w" returned by "gtk_dialog_add_button(dialog, "gtk-cancel", -2)" is never used.

    Error: UNUSED_VALUE (CWE-563): [#def17]
    network-manager-applet-0.9.9.0/src/mobile-helpers.c:452: returned_pointer: Pointer "ok_button" returned by "gtk_dialog_add_button(dialog, "gtk-cancel", -2)" is never used.

    Error: UNUSED_VALUE (CWE-563): [#def18]
    network-manager-applet-0.9.9.0/src/applet-device-ethernet.c:368: returned_pointer: Pointer "w" returned by "gtk_dialog_add_button((GtkDialog *)g_type_check_instance_cast((GTypeInstance *)info->dialog, gtk_dialog_get_type()), "gtk-cancel", -2)" is never used.

## Scan Properties

analyzer | coverity
analyzer-args | --wait-for-license -co BAD_FREE:allow_first_field:true
analyzer-version | Coverity Static Analysis for C/C++ version 6.5.3 on Linux 2.6.32-279.el6.x86_64 x86_64\nInternal version numbers: 7d3b4ace9c p-davis-push-13307.195
compilation-unit-count | 78
compilation-unit-ratio | 100
host | cov01.lab.eng.brq.redhat.com
lines-processed | 122251
mock-config | rhel-7-x86_64
project-name | network-manager-applet-0.9.9.0-7.git20131107.el7
time-created | 2013-11-08 08:04:52
time-elapsed-analysis | 00:00:37
time-finished | 2013-11-08 08:18:35
tool | cov-mockbuild
tool-args | 'rhel-7-x86_64' '/tmp/covscan_ejz2RV/network-manager-applet-0.9.9.0-7.git20131107.el7.src.rpm'
tool-version | cov-mockbuild-0.20131016_ed962af-1.el6.noarch csdiff-0.20131105_358ec25-1.el6.x86_64